-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move entirely to array-based SIMD #1624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmcm
force-pushed
the
array-simd
branch
8 times, most recently
from
August 7, 2024 09:21
a40f965
to
fed65ae
Compare
scottmcm
force-pushed
the
array-simd
branch
5 times, most recently
from
August 7, 2024 17:23
320ab21
to
634fd95
Compare
See MCP#621 This tries to make as few changes as possible -- it keeps the `new` functions taking all the parameters, for example.
scottmcm
force-pushed
the
array-simd
branch
2 times, most recently
from
August 7, 2024 19:38
db562ea
to
56a05aa
Compare
This ended up way more annoying than expected, because I needed to refactor the `types!` macro to separate out the stability attributes to put those on the `Debug` impl without also copying all the `#[doc]`s. But I like how it came out in the end, reducing duplication in the macro invocations. But without it all the C-consistency tests fail.
Looks like I finally got this working! 🎉 Some context for the review:
Overall, I'm super-happy to see diffs like - pub struct v32i8(
- pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8,
- pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8,
- pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8,
- pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8,
- );
+ pub struct v32i8(32 x pub(crate) i8); because man was that too much copy-paste for my taste. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 9, 2024
Update stdarch submodule To pick up rust-lang/stdarch#1624 and unblock removing support for non-array-based-simd (rust-lang/compiler-team#621). try-job: dist-aarch64-linux try-job: dist-armv7-linux try-job: dist-x86_64-linux
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 13, 2024
Update stdarch submodule To pick up rust-lang/stdarch#1624 and unblock removing support for non-array-based-simd (rust-lang/compiler-team#621). try-job: dist-aarch64-linux try-job: dist-armv7-linux try-job: dist-x86_64-linux
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2024
Update stdarch submodule To pick up rust-lang/stdarch#1624 and unblock removing support for non-array-based-simd (rust-lang/compiler-team#621).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See MCP#621
This tries to be very mechanical. It's not doing anything particularly smart and it's not changing any function signatures. Just adding
[]
s around things, or sometimes usingarray repeatssplats instead of manual repeats.